Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello,

In vcl, I've got this :
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:
In member function ‘void GraphiteLayout::fillFrom(gr_segment*,
ImplLayoutArgs&, float)’:
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:333:49:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:334:48:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:343:56:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
/home/maryline/compile-libreoffice/libo/vcl/source/glyphs/graphite_layout.cxx:357:49:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
cc1plus: all warnings being treated as errors

It's due to the commit 162676cb6a940636e958b5787a626d814865ab86.

example of code :
           size_t bFirstChar = gr_cinfo_base(gr_seg_cinfo(pSegment,
nFirstCharInCluster));
            if (mnSegCharOffset + bFirstChar >= mnMinCharPos &&
                mnSegCharOffset + bFirstChar < mnEndCharPos)

I propose the patch below with static cast but perhaps all the variables
should be of the same type (unsigned int or signed int).

http://nabble.documentfoundation.org/file/n3359780/patch_glyph.txt
patch_glyph.txt 

If the static cast is ok, I can commit and push on master.

Julien.


--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-simple-fix-for-vcl-glyph-part-tp3359780p3359780.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.