Re: [Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

On 22.09.2011 18:51, Bjoern Michaelsen wrote:
> Hi Cedric, Hi Caolan,
>
> could you please review:
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac1912ecb13709082026428d2b2a56c4915b939f
>
> for backporting to -3-4? It kills the footnotes before killing the rest
> of the layout saving us from the trouble later. It seems to fix the
> problem with the test document here and also that fix passes all
> unittests and subequenttests on master.

is this the kind of crash that was introduced by mba's layout refactoring
(moving the layout from the model to the view) that went into one of the
last DEV300 milestones?

i think the workaround for OOo 3.4 was this:
http://svn.apache.org/viewvc?rev=1172362&view=rev

wonder what Oliver and Mathias had in mind as the proper fix...


if your patch helps then i don't object to it, but i'd really like a
comment in the added line why it's been added (which is certainly
non-obvious here).

-- 
ENOSIG