Re: [Libreoffice] [PATCH] bug fdo#37164

On 20/09/11 16:27, Caolán McNamara wrote:
> On Tue, 2011-09-20 at 09:59 +0100, Noel Power wrote:
> > I'm looking for someone to bless/approve ( and or ) commit the patch to
> > the 3.4 branch
> The only things outside of testtool which are touched look like an early
> return from SbFormFactory::CreateObject if vba is enabled and a removed
> HelpID from the built-in file dialog, those two changes are needed for
> this right ?
correct, the SbFormFactory::CreateObject calls 'Find' which ends up in 
the testtool code and throws an error for some reason I can't recall, 
the SbFormFactory only does something useful if the result of the 'Find' 
is a SbUserFormModule which is a compatability module ( e.g. for 
UserForms ) so returning early prevents the error and the lets the 
testtool continue.

The HelpID that is removed I would guess is probably the product of a 
bad merge, the removed HelpId is bogus, is in the wrong place and 
actually overwrites the HID of the file picker itself, again this caused 
some failure when executing the test.
> How do we test this thing again ?
always it seems with difficulty and pain, but... with a suitable 
.testoolrc in your home directory ( see my working copy attached ) file 
with the correct entries things *should* work out of the box

so.. all you need to do is just copy the .testtoolrc into your home 
directory, fire up an editor and edit the paths as appropriate ( there 
is some option to actually fill in the right details from the testtool 
gui but I never have used that )

just run the testtool from the cmd line e.g.

[INSTALL_PATH]/basis-link/program/testtool.bin

open a test such as

testautomation/framework/required/f_topten.bas

press F5 to run

( do it all from the cmd line if you like 
[INSTALL_PATH]/basis-link/program/testtool.bin -run 
testautomation/framework/required/f_topten.bas )

the test above runs in a reasonable amount of time ( couple of minutes ) 
and should have no errors and some ( 4 iirc ) warnings


Noel

[Misc]
ServerTimeout=4500
StopOnSyntaxError=0
CurrentProfile=_profile_Novell OOo-2.0

[Path]
BaseDir=
LogBaseDir=
HIDDir=

[GUI Platform]
Current=03
All=03

[WinGeom]
WinParams=492,40,1124,919;1;0,0,0,0;

[_profile_Novell OOo-2.0]
LogBaseDir=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/logs
BaseDir=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation
HIDDir=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/global/hid
AutoReload=0
AutoSave=0
StopOnSyntaxError=0
*.bas=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/global/system/includes
LastFilterName=Include files (*.INC)

[OOoProgramDir]
Current=/data4/libreoffice-3-4/bootstrap/INSTALL_TESTLINK
Type=PATH

[Crashreporter]
UseProxy=false
ProxyServer=
ProxyPort=1024
AllowContact=false
ReturnAddress=

[Communication]
Host=localhost
TTPort=12479
UnoPort=65535

[LRU]
MaxLRU=4
LRU1=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/framework/required/f_topten.bas
LRU2=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/global/system/includes/master.inc

[_profile_Default]
BaseDir=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation
HIDDir=/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/global/hid
LogBaseDir=/tmp

[Breakpoints]
/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/global/system/includes/master.inc=427
/data4/libreoffice-3-4/bootstrap/clone/testing/testautomation/global/system/includes/master.inc=1138