On Thu, Sep 15, 2011 at 02:43:06PM -0700, julien2412 wrote:
Hello,
Here is a patch on 2 different code parts. Cppcheck detected these :
core/vcl/source/gdi/sallayout.cxx
743 bitwiseOnBoolean style Boolean variable 'bAllOk' is used in bitwise
operation. Did you mean && ?
Yes, that should be &&.
core/sfx2/source/appl/workwin.cxx
1073 bitwiseOnBoolean style Boolean variable 'bInvisible' is used in bitwise
operation. Did you mean && ?
Actually the "bInvisible &" part is not even necessary there (the law of
excluded middle).
They seem not "false positive" or some kind of "C++ trick" in my opinion but
I'd like your opinion about them.
As usual, if you think it's ok, I can commit and push them on master.
Please do.
D.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.