[Libreoffice] gbuildized xml2cmp breaks Windows (was: Tinderbox failure, last success: 2011-09-13 20:44:55)

On 09/15/2011 09:11 AM, Stephan Bergmann wrote:
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=e728feaeebae96df5566bdb6d5f0458983d843ad>
> "On Windows, xml2cmp depends on uwinapi from sal." should probably fix
> the below problem.

Turns out that that fix (making xml2cmp depend on sal) introduced a 
circular dependency (as sal already depends on xml2cmp).

The problem is that before gbuildization, xml2cmp was careful not to 
link against uwinapi (via UWINAPILIB=$(0) in xml2cmp/util/makefile.mk); 
this needs to be re-implemented in gbuild.

-Stephan

> On 09/15/2011 08:47 AM, kendy@suse.cz wrote:
> > Hi folks,
> >
> > One of you broke the build of LibreOffice with your commit :-(
> > Please commit and push a fix ASAP!
> >
> > Full log available at http://tinderbox.libreoffice.org/MASTER/status.html
> >
> > Tinderbox info:
> >
> > Box name: Windows XP SP3
> > Machine: CYGWIN_NT-5.1 steve 1.7.9(0.237/5/3) 2011-03-29 10:10 i686
> > Cygwin
> > Configured with: --disable-directx
> > --disable-mozilla
> > --without-junit
> > --disable-binfilter
> > --with-ant-home=/home/kendy/apache-ant-1.8.1
> >
> > Commits since the last success:
> >
> > ==== core ====
> > 45589f1 gbuildize automation
> > 6c8a7e0 pass -s flag to custom target's make process
> > a3c3d70 be silent
> > c79e42d be silent
> > c40f634 work silently for make -s
> > 37356b7 allow to specify additional deps for zip target
> > 0510c98 WaE: declaration of 'index' shadows a global declaration
> > b2d9db4 WaE: declaration of 'i' shadows a previous local
> > 30bf29f WaE: declaration of 'j' shadows a previous local
> > 7a7f10e forgot another csv file
> > 4fe0797 add formats test for xls and xlsx
> > 2b75f59 improve calc's format unit test
> > 032fca6 deliver libcrmf.a
> > 0c113d8 Fix of localised template name problems in Impress part 1
> > b6cccb9 Fix nSearchType vs. nMatchType typo and simplify resulting code.
> > fb1e454 Don't always set refresh flag on export. This is a bad hack.
> > 2f65414 Check the source range when refreshing, and abort refresh if
> > invalid.
> > 932ee04 Introduced CHECK_PARALLELISM (and poshed the code up).
> > a75cb23 default shortcut for .uno:SearchDialog should be Ctrl+H
> > 27dcdb1 New unit test case for testing SHEETS function result.
> > dd482fd do not try to read from an iterator which we just deleted from
> > the container
> > e26ea36 Revert "Revert "i#118224: kill O(n^2) complexity of unique
> > bookmark name creation""
> > 9015c60 Do the same when calling ScDocument::InsertTabs().
> > 892f8b5 fdo#35965: Mark all formula cells dirty when appending a new
> > sheet.
> > b7998b6 No need to bark about G_SLICE on stderr.
> > 188696a don't crash
> > b7912ec don't quote ???x???
> > 0a97ece merge srvdepy functions into xml2cmp and simplify xml2cmp gbuild
> > 8578e3c Related: fdo#40599 add a initial basic test for deleting graphics
> > c046147 Folded smoketestdoc back into smoketestoo_native; no need to
> > have it separated.
> > 05a6605 Revert "i#118224: kill O(n^2) complexity of unique bookmark
> > name creation"
> > 387620b Removed solenv/bin/subsequenttests, moved its (improved)
> > content directly into Makefile.in.
> > 109ca35 Added more missing dependencies on solenv back into build.lsts.
> > 333648c added twofold affix+compound to hunspell, as the official
> > fixed
> > https://sourceforge.net/tracker/index.php?func=detail&aid=3288562&group_id=143754&atid=756395
> >
> > 6caaa5e default to -r on gbuild for performance (assumed esp. on make
> > 3.82)
> > 79dc19f ByteString->rtl::OStringBuffer
> > 98ae11b pointless foo
> > 33aa323 callcatcher: remove unused code
> > 4a3db11 ImplUpdateStringFromUniString is now dangling
> > 1cd1e4a use read_uInt8s_AsOString here
> > 84db141 forgot the csv file for number formats
> > 61732a8 add unit test for formated cells
> > b6d3f5c ScCompiler::IsDBRange compares upper case strings
> > ba361f9 add database unit test
> > 32ca2cb Updated csv_parser from orcus.
> > 689bde9 Some cppcheck cleaning
> > ==== dictionaries ====
> > ==== help ====
> >
> > The error is:
> >
> > build failed - error is:: log for /cygdrive/c/libo/xml2cmp/prj
> > cd ..&& make -s -r -j1&& make -s -r deliverlog
> > [ info ALL ] LinkTarget Library/uwinapi.lib not defined: Assuming
> > headers to be there!
> > [ info ALL ] LinkTarget Library/advapi32.lib not defined: Assuming
> > headers to be there!
> > [ build CXX ] xml2cmp/source/xcd/main
> > [ build CXX ] xml2cmp/source/support/cmdline
> > [ build CXX ] xml2cmp/source/support/heap
> > [ build CXX ] xml2cmp/source/support/sistr
> > [ build CXX ] xml2cmp/source/support/syshelp
> > [ build CXX ] xml2cmp/source/support/badcast
> > [ build CXX ] xml2cmp/source/xcd/cr_html
> > [ build CXX ] xml2cmp/source/xcd/cr_index
> > --
> > [ build CXX ] xml2cmp/source/xcd/cr_metho
> > [ build CXX ] xml2cmp/source/xcd/filebuff
> > [ build CXX ] xml2cmp/source/xcd/parse
> > [ build CXX ] xml2cmp/source/xcd/xmlelem
> > [ build CXX ] xml2cmp/source/xcd/xmltree
> > [ build CXX ] xml2cmp/source/xcd/dependy
> > [ build DEP ] LNK:Executable/xml2cmp.exe
> > [ build DEP ] LNK:Executable/xml2cmp.exe
> > [ build DEP ] LNK:Executable/xml2cmp.exe
> > [ build LNK ] Executable/xml2cmp.exe
> > Microsoft (R) Incremental Linker Version 9.00.21022.08
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/main.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/cmdline.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/heap.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/sistr.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/syshelp.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/badcast.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_html.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_index.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_metho.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/filebuff.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/parse.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmlelem.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmltree.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/dependy.o
> > LINK : fatal error LNK1181: cannot open input file 'uwinapi.lib'
> > make[1]: ***
> > [/cygdrive/c/libo/workdir/wntmsci12.pro/LinkTarget/Executable/xml2cmp.exe]
> > Error 157
> > dmake: Error code 2, while making 'all'
> > log for /cygdrive/c/libo/xml2cmp/prj
> > cd ..&& make -s -r -j1&& make -s -r deliverlog
> > [ build LNK ] Executable/xml2cmp.exe
> > Microsoft (R) Incremental Linker Version 9.00.21022.08
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/main.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/cmdline.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/heap.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/sistr.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/syshelp.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/badcast.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_html.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_index.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_metho.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/filebuff.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/parse.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmlelem.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmltree.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/dependy.o
> > LINK : fatal error LNK1181: cannot open input file 'uwinapi.lib'
> > make[1]: ***
> > [/cygdrive/c/libo/workdir/wntmsci12.pro/LinkTarget/Executable/xml2cmp.exe]
> > Error 157
> > dmake: Error code 2, while making 'all'
> > log for /cygdrive/c/libo/xml2cmp/prj
> > cd ..&& make -s -r -j1&& make -s -r deliverlog
> > [ build LNK ] Executable/xml2cmp.exe
> > Microsoft (R) Incremental Linker Version 9.00.21022.08
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/main.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/cmdline.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/heap.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/sistr.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/syshelp.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/badcast.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_html.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_index.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_metho.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/filebuff.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/parse.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmlelem.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmltree.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/dependy.o
> > LINK : fatal error LNK1181: cannot open input file 'uwinapi.lib'
> > make[1]: ***
> > [/cygdrive/c/libo/workdir/wntmsci12.pro/LinkTarget/Executable/xml2cmp.exe]
> > Error 157
> > dmake: Error code 2, while making 'all'
> > log for /cygdrive/c/libo/xml2cmp/prj
> > cd ..&& make -s -r -j1&& make -s -r deliverlog
> > [ build LNK ] Executable/xml2cmp.exe
> > Microsoft (R) Incremental Linker Version 9.00.21022.08
> > Copyright (C) Microsoft Corporation. All rights reserved.
> >
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/main.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/cmdline.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/heap.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/sistr.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/syshelp.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/support/badcast.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_html.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_index.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/cr_metho.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/filebuff.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/parse.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmlelem.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/xmltree.o
> > c:/libo/workdir/wntmsci12.pro/CxxObject/xml2cmp/source/xcd/dependy.o
> > LINK : fatal error LNK1181: cannot open input file 'uwinapi.lib'
> > make[1]: ***
> > [/cygdrive/c/libo/workdir/wntmsci12.pro/LinkTarget/Executable/xml2cmp.exe]
> > Error 157
> > dmake: Error code 2, while making 'all'
> > ======
> > ERROR: error 65280 occurred while making /cygdrive/c/libo/xml2cmp/prj