Re: [Libreoffice] [REVIEW] cherry-pick to 3-4: fix fdo#40590 defined names not resolved during file load

On Sun, 2011-09-11 at 15:37 +0200, Eike Rathke wrote:
> Hi,
>
> Please review and cherry-pick to 3-4
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f42e4d03b04204b7a864f3c5c9c03548f5e2392
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=34c9a01b075788653b89c244eb8b3fcee54bfa68
>
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=40590

Hi Eike,

So, I've reviewed your changes, and confirms that it indeed fixes the
use case reported in fdo#40590.

However, while trying to re-create a test case for our unit test, I've
discovered an issue.  I'd like to get your take on it.

Here is what I did.

1. Create a new spreadsheet document.
2. Go to Insert - Names - Define
3. Create a new name MyName1 and assign "1+2" to it.  Push Add to add
this name, but don't close the dialog yet.
4. Create a new name MyName2 and assign "MyName1*10".  Push Add to add
this name.
5. MyName2 becomes myname1*10 (all lowercase), which is a sign that the
name compilation has failed.

Having said this, this problem already exists before your changes, so
I'm fine cherry-picking these commits to at least fix the reported case.
Let me do a little more review before making the final call.  The change
is non-trivial, so I have to dig a little more to understand this code
change...

Regards,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc