Re: [Libreoffice] [PUSHED 3.4] fix javaldx call in oosplash

Hi Lionel,

On Monday, 2011-09-12 01:17:32 +0200, Lionel Elie Mamane wrote:

> Looks good & low-risk to me, pushed.

You were 8 minutes faster than me ;)

Please attribute the proper author in commits, either use git am or stg
import -m or some such to read in the patch from a mail, or explicitly
set the author with git commit --author=...

Also, a Signed-off-by line on 3-4 branch commits is nice to have (or do
we even require it?), in this case you're committer and reviewer in one
person so you'd add yourself to that, again with git am --signoff or stg
import --sign or git commit --signoff

Thanks
  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: signature.asc
Description: Digital signature