Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hello,

Cppcheck detected this :
core/jvmfwk/source/elements.cxx
127 assignBoolToPointer error Assigning bool value to pointer (converting bool value to address)

Here is a simple patch :

diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx
index bb5cf62..b54e380 100644
--- a/jvmfwk/source/elements.cxx
+++ b/jvmfwk/source/elements.cxx
@@ -124,7 +124,7 @@ void createSettingsStructure(xmlDoc * document, bool * bNeedsSave)
     }
     if (bFound)
     {
-        bNeedsSave = false;
+        *bNeedsSave = false;
         return;
     }
     //We will modify this document

Too simple to be true ? I prefer asking instead of having missed a "special C++ trick".

Julien.
(As usual, I can of course commit and push it on master if it's ok).

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.