Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


Hi,

In your commit 291b85778669b4e4e276faab22add9d0e80046df
(Build our mozilla (module moz) against the nss we have built anyway.)

This hunk:

--- a/moz/makefile.mk
+++ b/moz/makefile.mk
@@ -174,7 +184,7 @@ MOZ_CROSSCOMPILE=CROSS_COMPILE=1 CC="$(CC) -arch $(MOZ_ARCH)" CXX="$(CXX) -arch
 
 CONFIGURE_ACTION=$(null,$(MOZ_ARCH) $(NULL) $(MOZ_CROSSCOMPILE)) ../configure 
$(MOZILLA_CONFIGURE_FLAGS)
 
-BUILD_ACTION:=$(GNUMAKE) -j$(EXTMAXPROCESS)
+BUILD_ACTION:=cd mozilla/X_objdir/xpcom ; $(GNUMAKE) -j$(EXTMAXPROCESS)
 
 .IF "$(GUI)"=="UNX"
 .IF "$(COMNAME)"=="sunpro5"


Does not do what you intend from it.

1) Not robust: if the cd fails, the next command (make) is run
   anyway. Please use "&&" instead of ";" when chaining commands.

2) solenv/inc/tg_ext.mk prepends "cd $(P_BUILD_DIR) && " when calling
   BUILD_ACTION, so what is done is e.g.:

   cd misc/build/mozilla/X_objdir && cd mozilla/X_objdir/xpcom ; $(GNUMAKE) -j$(EXTMAXPROCESS)

   the second cd fails and thus make is executed in X_objdir and not
   in xpcom.

   Doing make only in xpcom fails from a clean state (some files that
   are needed are not built), so I've completely reverted that hunk for
   now. Feel free to do whatever you meant by this hunk in a way that
   works :)

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.