Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument.

Stephan Bergmann <sbergman -AT- redhat.com>
Tue, 06 Sep 2011 12:59:20 +0200

On 09/06/2011 12:25 PM, Noel Power wrote:

Hi Stephan,
On 06/09/11 10:07, Stephan Bergmann wrote:

Found a regression from a recent "Disable fake VBA events for the
old-style form controls" commit that causes the forms/qa/unoapi check
to fail. Attached patch fixes it.

-Stephan

thanks for fixing, ( I see Caolán pushed ) btw what exactly was null /me
just doesn't see where/why moving the getPropertyValue makes a difference.

The unoapi tests call insertByIndex with a null interface,approveNewElement called from OInterfaceContainer::implInsert checks fornull and throws an exception, but your modification accessed _rxElementbefore it got passed to approveNewElement.


-Stephan

Context

[Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument. · Stephan Bergmann
- Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument. · Caolán McNamara
  - Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument. · Bjoern Michaelsen
- Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument. · Noel Power
  - Re: [Libreoffice] [PATCH] frm::OInterfaceContainer::insertByIndex must not crash for null argument. · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.