Hi Kohei, On Sunday, 2011-09-04 20:09:30 -0400, Kohei Yoshida wrote:
Sounds good. So, do you think that these two commits combined (my original and your fix) would be safe enough to be backported to the stable (3.4) branch, or ...? What's your opinion?
Pushed to 3-4 http://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4&id=65799e2c71ad5d8c4eda4feeda33ceb774726260 http://cgit.freedesktop.org/libreoffice/calc/commit/?h=libreoffice-3-4&id=a961f15ce8dbf5bfbeb2b853cd82624f3a4c0692 I also tested with the OOo definednames*.xls* testcases, no difference except that 3.4.2 [I should install 3.4.3 ...] crashed on two which it doesn't on current 3-4 While at it I discovered that another fix (already on master) is needed regarding name crashers, I'll throw in a review request. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD
Attachment:
signature.asc
Description: Digital signature