[Libreoffice] [REVIEW] svgwriter SVGActionWriter::ImplWriteText uses auto_prt with new[]

julien2412 <serval2412 -AT- yahoo.fr>
Sat, 3 Sep 2011 01:43:43 -0700 (PDT)

Hello,

Cppcheck detected the use of an auto_ptr with new [] in
filter/source/svg/svgwriter.cxx (line 1145). Since, auto_ptr shouldn't be
used with new[] because it always does a delete (and not a delete[] in this
case), the code should be changed. So I thought about using
boost::shared_array.

I attached a patch. Is this one correct ? (if yes, I can of course commit
and push it on master).

Julien. http://nabble.documentfoundation.org/file/n3306210/patch_svg.txt
patch_svg.txt 

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-svgwriter-SVGActionWriter-ImplWriteText-uses-auto-prt-with-new-tp3306210p3306210.html
Sent from the Dev mailing list archive at Nabble.com.

Context

[Libreoffice] [REVIEW] svgwriter SVGActionWriter::ImplWriteText uses auto_prt with new[] · julien2412
- Re: [Libreoffice] [PUSHED] [REVIEW] svgwriter SVGActionWriter::ImplWriteText uses auto_prt with new[] · Thorsten Behrens
  - [Libreoffice] [REVIEW] new patch for svgwriter · julien2412
    - [Libreoffice] [PUSHED][REVIEW] new patch for svgwriter · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.