On Sat, 2011-08-27 at 02:04 +0200, Markus Mohrhard wrote:
Hello Caolan, all,
I just had some problems with my debug build in ucb and discovered
that at least one method only needed in a debug build has been
removed. It seems it was mentionend on unusedcode.easy, so my question
is how we should deal with these cases.
Yeah, the unusedcode.easy list is generated on an x86_64 Linux
--enable-dbgutil configuration, so code only used under higher debug
levels appears, as does code that is e.g. platform/different
configuration specific.
Like sb says, the typical solution is to put the definition/declaration
of the code behind the same ifdefs as the uses. And in this specific
case it looks sort of useless anyway so can just fix the assert.
Removing the lines from the list doesn't help, as I regenerate the list
regularly. Similar issue arises with "cool code that we'll use soon, but
not yet". Normally soon never happens :-) but if someone wants to
protect their code from getting removed stick ifdef TOMORROW or
something around it which has the desired outcome of not including the
unused code in the final build.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.