Re: [Libreoffice] code simplification: please logic review, to be sure

Eike Rathke <ooo -AT- erack.de>

Sat, 27 Aug 2011 23:18:09 +0200

Hi Pierre-André, On Friday, 2011-08-26 22:23:07 +0200, Pierre-André Jacquod wrote:

But this basically, this just ensure that the return value is not
NULL (comparing the pointer SwFrm* with 0 )

So I though the final version to be:
if( 0 != ( pONd = aIdx.GetNode().GetOLENode() ) &&
            aName.Equals( pONd->GetChartTblName() ) &&
            pONd->getLayoutFrm( rVSh.GetLayout()         )
        {....
        }

Did I missed something with my logic ?

No, looks fine. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

Attachment: signature.asc
Description: Digital signature

Context

[Libreoffice] code simplification: please logic review, to be sure · Pierre-André Jacquod

Re: [Libreoffice] code simplification: please logic review, to be sure · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.