[Libreoffice] [REVIEW]patch improving calc file loading time

Hi all

could you please have a look at this patch

it avoids multiple calls to maTables.back() that waste time on loading a
calc file. the idea is to store the last table needed and use this
instead of retreiving it each time from maTables

on a pathological calc file this drastically improve the loading time
(near 35% in certains cases)

this patch is based on 3.4 branch and targets the 3.4.4 at least

thanks again to markus for his great mentoring

Laurent

From b144f825cd7f12b516348473391dc8a67f4539d9 Mon Sep 17 00:00:00 2001
From: Laurent Godard <oooconv@free.fr>
Date: Wed, 24 Aug 2011 19:09:19 +0200
Subject: [PATCH] avoid maTables.back() calls by store and reuse when needed

better performance on loadin calc files (esp. big ones)
---
 sc/source/filter/xml/xmlsubti.cxx |   99 ++++++++++++++++++++-----------------
 sc/source/filter/xml/xmlsubti.hxx |    3 +-
 2 files changed, 55 insertions(+), 47 deletions(-)

diff --git a/sc/source/filter/xml/xmlsubti.cxx b/sc/source/filter/xml/xmlsubti.cxx
index 4b1316e..e769fa5 100644
--- a/sc/source/filter/xml/xmlsubti.cxx
+++ b/sc/source/filter/xml/xmlsubti.cxx
@@ -68,7 +68,7 @@ using ::std::auto_ptr;
 using namespace com::sun::star;
 
 ScMyTableData::ScMyTableData(sal_Int32 nSheet, sal_Int32 nCol, sal_Int32 nRow)
-    :  nColsPerCol(nDefaultColCount, 1),
+    :   nColsPerCol(nDefaultColCount, 1),
         nRealCols(nDefaultColCount + 1, 0),
         nRowsPerRow(nDefaultRowCount, 1),
         nRealRows(nDefaultRowCount + 1, 0),
@@ -163,7 +163,8 @@ ScMyTables::ScMyTables(ScXMLImport& rTempImport)
     nCurrentColStylePos(0),
     nCurrentDrawPage( -1 ),
     nCurrentXShapes( -1 ),
-    nCurrentSheet( -1 )
+    nCurrentSheet( -1 ),
+    pLastTable(NULL)
 {
 }
 
@@ -179,6 +180,7 @@ void ScMyTables::NewSheet(const rtl::OUString& sTableName, const rtl::OUString&
         nCurrentColStylePos = 0;
         sCurrentSheetName = sTableName;
         maTables.clear();
+        pLastTable = NULL;
         ++nCurrentSheet;
 
         maProtectionData = rProtectData;
@@ -336,12 +338,11 @@ void ScMyTables::DoMerge(sal_Int32 nCount)
         uno::Reference <table::XCellRange> xMergeCellRange;
         if (nCount == -1)
         {
-            const ScMyTableData& r = maTables.back();
             xMergeCellRange.set(
                 xCurrentCellRange->getCellRangeByPosition(
                     aCellAddress.StartColumn, aCellAddress.StartRow,
-                    aCellAddress.EndColumn + r.GetColsPerCol(r.GetColumn()) - 1,
-                    aCellAddress.EndRow + r.GetRowsPerRow(r.GetRow()) - 1));
+                    aCellAddress.EndColumn + pLastTable->GetColsPerCol(pLastTable->GetColumn()) - 
1,
+                    aCellAddress.EndRow + pLastTable->GetRowsPerRow(pLastTable->GetRow()) - 1));
         }
         else
             xMergeCellRange.set(
@@ -362,8 +363,8 @@ void ScMyTables::InsertRow()
     {
         table::CellRangeAddress aCellAddress;
         sal_Int32 nRow(GetRealCellPos().Row);
-        const ScMyTableData& rTab = maTables.back();
-        for (sal_Int32 j = 0; j < GetRealCellPos().Column - rTab.GetColumn() - 1; ++j)
+
+        for (sal_Int32 j = 0; j < GetRealCellPos().Column - pLastTable->GetColumn() - 1; ++j)
         {
             if (IsMerged(xCurrentCellRange, j, nRow - 1, aCellAddress))
             {
@@ -391,7 +392,7 @@ void ScMyTables::NewRow()
     if (n <= 1)
         return;
 
-    if (maTables[n-1].GetRealRows(maTables[n-1].GetRow()) >
+    if (pLastTable->GetRealRows(pLastTable->GetRow()) >
         maTables[n-2].GetRowsPerRow(maTables[n-2].GetRow()) - 1)
     {
         if (GetRealCellPos().Column > 0)
@@ -413,15 +414,14 @@ void ScMyTables::NewRow()
 
 void ScMyTables::AddRow()
 {
-    ScMyTableData& rTab = maTables.back();
-    rTab.AddRow();
-    rTab.SetFirstColumn();
-    sal_Int32 nRow = rTab.GetRow();
+    pLastTable->AddRow();
+    pLastTable->SetFirstColumn();
+    sal_Int32 nRow = pLastTable->GetRow();
     if (nRow > 0)
         NewRow();
 
-    rTab.SetRealRows(
-        nRow + 1, rTab.GetRealRows(nRow) + rTab.GetRowsPerRow(nRow));
+    pLastTable->SetRealRows(
+        nRow + 1, pLastTable->GetRealRows(nRow) + pLastTable->GetRowsPerRow(nRow));
 }
 
 void ScMyTables::SetRowStyle(const rtl::OUString& rCellStyleName)
@@ -435,7 +435,8 @@ void ScMyTables::InsertColumn()
     {
         table::CellRangeAddress aCellAddress;
         sal_Int32 nCol(GetRealCellPos().Column);
-        sal_Int32 n = GetRealCellPos().Row - maTables.back().GetRow() - 1;
+        sal_Int32 n = GetRealCellPos().Row - pLastTable->GetRow() - 1;
+
         for (sal_Int32 j = 0; j <= n; ++j)
         {
             table::CellRangeAddress aTempCellAddress;
@@ -459,7 +460,7 @@ void ScMyTables::InsertColumn()
 
             //insert Cell
             sheet::CellInsertMode aCellInsertMode(sheet::CellInsertMode_RIGHT);
-            uno::Reference <sheet::XCellRangeMovement> xCellRangeMovement (xCurrentSheet, 
uno::UNO_QUERY);
+            uno::Reference <sheet::XCellRangeMovement> xCellRangeMovement (xCurrentSheet, 
uno::UNO_QUERY);
             xCellRangeMovement->insertCells(aTempCellAddress, aCellInsertMode);
 
             //merge
@@ -478,31 +479,33 @@ void ScMyTables::NewColumn(sal_Bool bIsCovered)
     if (bIsCovered)
         return;
 
-    ScMyTableData& rLastTab = maTables.back();
-    sal_Int32 nColCount = rLastTab.GetColCount();
-    sal_Int32 nSpannedCols = rLastTab.GetSpannedCols();
+    sal_Int32 nColCount = pLastTable->GetColCount();
+    sal_Int32 nSpannedCols = pLastTable->GetSpannedCols();
+
+
     if ( (nSpannedCols > nColCount) &&
-        (rLastTab.GetRow() == 0) &&
-        (rLastTab.GetColumn() == 0) )
+        (pLastTable->GetRow() == 0) &&
+        (pLastTable->GetColumn() == 0) )
+
     {
         if (nColCount > 0)
         {
             sal_Int32 FirstColsSpanned(nSpannedCols / nColCount);
             sal_Int32 LastColSpanned(FirstColsSpanned
-                + (nSpannedCols        % nColCount));
+                + (nSpannedCols % nColCount));
             for (sal_Int32 i = 0; i < nColCount - 1; ++i)
             {
-                rLastTab.SetColsPerCol(i, FirstColsSpanned);
-                rLastTab.SetRealCols(i + 1, rLastTab.GetRealCols(i) + FirstColsSpanned);
+                pLastTable->SetColsPerCol(i, FirstColsSpanned);
+                pLastTable->SetRealCols(i + 1, pLastTable->GetRealCols(i) + FirstColsSpanned);
             }
-            rLastTab.SetColsPerCol(nColCount - 1, LastColSpanned);
-            rLastTab.SetRealCols(
-                nColCount, rLastTab.GetRealCols(nColCount - 1) + LastColSpanned);
+            pLastTable->SetColsPerCol(nColCount - 1, LastColSpanned);
+            pLastTable->SetRealCols(
+                nColCount, pLastTable->GetRealCols(nColCount - 1) + LastColSpanned);
         }
     }
-    if (rLastTab.GetRealCols(rLastTab.GetColumn()) > nSpannedCols - 1)
+    if (pLastTable->GetRealCols(pLastTable->GetColumn()) > nSpannedCols - 1)
     {
-        if (rLastTab.GetRow() == 0)
+        if (pLastTable->GetRow() == 0)
         {
             InsertColumn();
             size_t n = maTables.size();
@@ -513,7 +516,7 @@ void ScMyTables::NewColumn(sal_Bool bIsCovered)
 
                 maTables[i-1].SetColsPerCol(nColPos,
                     maTables[i-1].GetColsPerCol(nColPos) +
-                    rLastTab.GetColsPerCol(rLastTab.GetColumn()));
+                    pLastTable->GetColsPerCol(pLastTable->GetColumn()));
 
                 maTables[i-1].SetRealCols(
                     nColPos + 1,
@@ -527,21 +530,20 @@ void ScMyTables::NewColumn(sal_Bool bIsCovered)
 
 void ScMyTables::AddColumn(sal_Bool bIsCovered)
 {
-    ScMyTableData& rLastTab = maTables.back();
-    rLastTab.AddColumn();
-    if (rLastTab.GetSubTableSpanned() > 1)
-        rLastTab.SetSubTableSpanned(rLastTab.GetSubTableSpanned() - 1);
+    pLastTable->AddColumn();
+    if (pLastTable->GetSubTableSpanned() > 1)
+        pLastTable->SetSubTableSpanned(pLastTable->GetSubTableSpanned() - 1);
     else
     {
         NewColumn(bIsCovered);
-        sal_Int32 nCol = rLastTab.GetColumn();
-        sal_Int32 nRow = rLastTab.GetRow();
-        rLastTab.SetRealCols(
-            nCol + 1, rLastTab.GetRealCols(nCol) + rLastTab.GetColsPerCol(nCol));
+        sal_Int32 nCol = pLastTable->GetColumn();
+        sal_Int32 nRow = pLastTable->GetRow();
+        pLastTable->SetRealCols(
+            nCol + 1, pLastTable->GetRealCols(nCol) + pLastTable->GetColsPerCol(nCol));
 
-        if ((!bIsCovered) || (bIsCovered && (rLastTab.GetColsPerCol(nCol) > 1)))
+        if ((!bIsCovered) || (bIsCovered && (pLastTable->GetColsPerCol(nCol) > 1)))
         {
-            if ((rLastTab.GetRowsPerRow(nRow) > 1) || (rLastTab.GetColsPerCol(nCol) > 1))
+            if ((pLastTable->GetRowsPerRow(nRow) > 1) || (pLastTable->GetColsPerCol(nCol) > 1))
                 DoMerge();
         }
     }
@@ -550,6 +552,7 @@ void ScMyTables::AddColumn(sal_Bool bIsCovered)
 void ScMyTables::NewTable(sal_Int32 nTempSpannedCols)
 {
     maTables.push_back(new ScMyTableData(nCurrentSheet));
+    pLastTable = &maTables.back();
 
     if (maTables.size() > 1)
     {
@@ -577,13 +580,12 @@ void ScMyTables::NewTable(sal_Int32 nTempSpannedCols)
             nTempSpannedCols += nToMerge;
     }
 
-    ScMyTableData& rNewTab = maTables.back();
-    rNewTab.SetSpannedCols(nTempSpannedCols);
+    pLastTable->SetSpannedCols(nTempSpannedCols);
 
     size_t n = maTables.size();
     if (n > 1)
     {
-        maTables[n-2].SetSubTableSpanned(rNewTab.GetSpannedCols());
+        maTables[n-2].SetSubTableSpanned(pLastTable->GetSpannedCols());
         UnMerge();
     }
 }
@@ -636,7 +638,13 @@ void ScMyTables::DeleteTable()
 
     nCurrentColStylePos = 0;
     if (!maTables.empty())
-        maTables.pop_back();
+    {
+          maTables.pop_back();
+          if (maTables.empty())
+               pLastTable = NULL;
+          else
+               pLastTable = &maTables.back();
+    }
 
     if (maTables.empty()) // only set the styles if all subtables are importet and the table is 
finished
     {
@@ -705,8 +713,7 @@ table::CellAddress ScMyTables::GetRealCellPos()
 
 void ScMyTables::AddColCount(sal_Int32 nTempColCount)
 {
-    ScMyTableData& rLastTab = maTables.back();
-    rLastTab.SetColCount(rLastTab.GetColCount() + nTempColCount);
+    pLastTable->SetColCount(pLastTable->GetColCount() + nTempColCount);
 }
 
 void ScMyTables::AddColStyle(const sal_Int32 nRepeat, const rtl::OUString& rCellStyleName)
diff --git a/sc/source/filter/xml/xmlsubti.hxx b/sc/source/filter/xml/xmlsubti.hxx
index e0a8d9a..0d817fb 100644
--- a/sc/source/filter/xml/xmlsubti.hxx
+++ b/sc/source/filter/xml/xmlsubti.hxx
@@ -143,7 +143,8 @@ private:
     sal_Int16                                                  nCurrentDrawPage;
     sal_Int16                                                  nCurrentXShapes;
     sal_Int32                                                  nCurrentSheet;
-
+    ScMyTableData*                      pLastTable;
+    
     sal_Bool                                                   IsMerged (const 
com::sun::star::uno::Reference <com::sun::star::table::XCellRange>& xCellRange,
                                                 const sal_Int32 nCol, const sal_Int32 nRow,
                                                 com::sun::star::table::CellRangeAddress& 
aCellAddress) const;
-- 
1.7.1