Re: [Libreoffice] [PUSHED][PATCH] fdo#40341: Writer crashes in page preview when clicking Formatting Aids

Hi Caolán,

On Wed, 24 Aug 2011 15:06:28 +0100, Caolán McNamara <caolanm@redhat.com> wrote:
> On Wed, 2011-08-24 at 19:06 +0900, Takeshi Abe wrote:
> > Hi all,
> >
> > A newly-reported fdo#40341
> > https://bugs.freedesktop.org/show_bug.cgi?id=40341
> > looks like a simple SEGV with a null pointer, which can be fixed by
> > the attached patch.
> > It also contains code hiding a checkbox for "Math baseline alignment"
> > in "Formatting Aids" if its current value is unavailable, like in
> > this case of 'Page Preview' mode.
> > Is it permissible? Any better way?
>
> Looks good to me anyway, so pushed to master.
Thank you for your review!

> Is this something that should be cherry-picked for 3-4 ?
My tiny +1 :)

Cheers,
-- Takeshi Abe

> C.
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice