Re: [Libreoffice] [PATCH] make graphite2 work on bigendian (was: Re: cherry pick graphite into 3.4.4)

Martin Hosken <martin_hosken -AT- sil.org>
Wed, 24 Aug 2011 00:07:42 +0700

Dear Michael,

On Tue, 2011-08-23 at 14:08 +0200, Rene Engelhard wrote:

Can commit to master tonight, and if someone agres I can also cherry-pick
to -3-4 then...


      Looks good to me :-) if I was paranoid, I'd point out that I'd prefer
the options to be "TRUE" vs. empty rather than:

    WORDS_BIGENDIAN=$ac_cv_c_bigendian

      but its just fine for 3.4.


We'll fix this in a later release (get rid of the need and use all together). But not worth 
changing the libo stuff just for that at this stage. What's in there is good to go.

Yours,
Martin

Context

[Libreoffice] cherry pick graphite into 3.4.4 · Martin Hosken
- Re: [Libreoffice] cherry pick graphite into 3.4.4 · Rene Engelhard
  - [Libreoffice] [PATCH] make graphite2 work on bigendian (was: Re: cherry pick graphite into 3.4.4) · Rene Engelhard
    - Re: [Libreoffice] [PATCH] make graphite2 work on bigendian (was: Re: cherry pick graphite into 3.4.4) · Michael Meeks
      - Re: [Libreoffice] [PATCH] make graphite2 work on bigendian (was: Re: cherry pick graphite into 3.4.4) · Martin Hosken
- [Libreoffice] [PUSHED] cherry pick graphite into 3.4.4 · Michael Meeks
- Re: [Libreoffice] cherry pick graphite into 3.4.4 · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.