Re: [Libreoffice] Rectangle width

Hello!

For example, there is small bug corresponding to this problem. See function «ImplDrawDropdownArrow» in «toolbox.cxx» («vcl» module).
A lines
    long x = rDropDownRect.Left() + (rDropDownRect.getWidth() - width)/2;
    long y = rDropDownRect.Top() + (rDropDownRect.getHeight() - height)/2;

use wrong functions getHeight() and getWidth() , but really should use GetHeight() and GetWidth().
So, this problem causes the dropdown arrows of menubuttons on toolboxes to be shifted left.

 

18.08.2011 13:21, Michael Meeks пишет:

On Wed, 2011-08-17 at 23:08 +0200, Thorsten Behrens wrote:

Hi Dmitry - yes, the two different methods are surely confusing. As
for the "wrong value", that very much depends on the mental model of
rectangles you're using. In a discrete geometry world (aka "pixel"),
the GetWidth() is correct. In a continuous geometry world (aka
"euclidean plane"), getWidth() is right.

	Ho ;-) Should we perhaps have some better naming: 'getOuterWidth' vs.
'getWidth' or something ;-)

This fundamental, conceptual difference is the historical reason for
the two methods (admittedly, not a very clean solution to the
problem).

	True - perhaps we should audit all calls of GetWidth on Rectangle to
see how many there are and update them if fewer than a couple of hundred
or so ?

	ATB,

		Michael.

-- 
Best Regards,
    Dmitry

begin:vcard
fn:Dmitry Ashkadov
n:Ashkadov;Dmitry
email;internet:dmitry.ashkadov@gmail.com
note:JID: dmitryash@jabber.mipt.ru
version:2.1
end:vcard