Re: [Libreoffice] cppu::OPropertySetHelper ABI backwards compatibility

On Mon, 2011-08-22 at 23:53 +0200, Eike Rathke wrote:
> There may be a way out of it: _append_ the new virtual function after
> all existing. This works only though if new code using it is not mixed
> with old implementation. Old code using the new implementation
> shouldn't see a problem as it expects the vtable to be shorter, unless
> someone derived from OPropertySetHelper then there may be problems
> again. Maybe too vague. 

Yeah this is confusing.  I'd rather we sub-class OPropertySetHelper2
from OPropertySetHelper to export the new interface to keep the ABI of
the original class.

But we still need to modify the original base class to have the
additional boolean member (m_bFireEvent) in order for the fire() method
to see that member and use it in that method.  I suppose there is no way
around it (?)

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida@suse.com>