Re: [Libreoffice] [PATCH] Enable CUPS unconditionally

On Sun, Aug 21, 2011 at 08:53:14PM +0200, Francois Tigeot wrote:
> -dnl check for cups support
> -dnl ===================================================================
> -AC_MSG_CHECKING([whether to enable native cups support])
> -if test "$test_cups" = "yes" -a "z$enable_cups" != "zno"; then
> -    ENABLE_CUPS="TRUE"
> -    AC_MSG_RESULT([yes])
> -    AC_CHECK_LIB(cups, cupsPrintFiles)
> -    AC_CHECK_HEADER(cups/cups.h, AC_DEFINE(HAVE_CUPS_H))
> -    if test "$ac_cv_lib_cups_cupsPrintFiles" != "yes" -a "$ac_cv_header_cups_cups_h" != "yes"; 
> then
> -        AC_MSG_ERROR([Could not find CUPS. Install libcupsys2-dev or cups???-devel.])
> -    fi
> -else
> -    ENABLE_CUPS=""
> -    AC_MSG_RESULT([no])
> -fi
> -AC_SUBST(ENABLE_CUPS)
> -
> -

Huh? No, that won't work.

You at least should keep the AC_CHECK_LIB/AC_CHECK_HEADER and the if so that we correctly
check for pre-requisites...

Otherwise, +1.

Grüße/Regards,

René
-- 
 .''`.  René Engelhard -- Debian GNU/Linux Developer
 : :' : http://www.debian.org | http://people.debian.org/~rene/
 `. `'  rene@debian.org | GnuPG-Key ID: D03E3E70
   `-   Fingerprint: E12D EA46 7506 70CF A960 801D 0AA0 4571 D03E 3E70