On Thu, 2011-08-18 at 01:57 -0500, Norbert Thiebaud wrote:
Guards are used and badly abused in the code, especially with the
infamous SolarMutex...
anything that would make that code slower or fatter than it already is
(with virtual functions and all), especially for corner-case
'you-are-about-to-die-anyway' scenario, is bad.
Right - throwing exceptions - or annotating methods as being able to
throw exceptions for corner cases that are highly unlikely seems like
just adding unwinding bloat for no major advantage.
so my opinion is, just let it be :-)
Ditto; good catch though Lionel - great to have some scrutiny of this
sort of issue: no doubt there are plenty of things that can fail that
are not handled correctly currently, and would be good to improve.
Thanks for caring !
All the best,
Michael.
--
michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.