Re: [Libreoffice] [PUSHED] sax build -vs- svn gcc

On 10/08/11 18:49, Tom Tromey wrote:
> I tried building LibreOffice with svn trunk gcc.
>
> It dies in sax with:
>
> In file included from 
> /home/tromey/Space/LibreOffice/bootstrap/sax/source/tools/fastserializer.cxx:33:0:
> /home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx: In instantiation of 
> ‘void comphelper::SequenceAsVector<TElementType>::operator<<(const 
> com::sun::star::uno::Sequence<T>&) [with TElementType = int]’:
> /home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:111:13:   
> required from ‘comphelper::SequenceAsVector<TElementType>::SequenceAsVector(const 
> com::sun::star::uno::Sequence<T>&) [with TElementType = int]’
> /home/tromey/Space/LibreOffice/bootstrap/sax/source/tools/fastserializer.cxx:468:55:   required 
> from here
> /home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:150:17:
>  error: ‘push_back’ was not declared in this scope, and no declarations were found by 
> argument-dependent lookup at the point of instantiation [-fpermissive]
> /home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:150:17: 
> note: declarations in dependent base ‘std::vector<int, std::allocator<int>  >’ are not found by 
> unqualified lookup
> /home/tromey/Space/LibreOffice/bootstrap/solver/350/unxlngx6.pro/inc/comphelper/sequenceasvector.hxx:150:17:
>  note: use ‘this->push_back’ instead
>
>
> The appended patch fixes this problem by adding a 'this->' qualifier.
>
> This is contributed under the LGPLv3+/MPL.
>
> Tom
>
> diff --git a/o3tl/inc/o3tl/vector_pool.hxx b/o3tl/inc/o3tl/vector_pool.hxx
> index 6ef4e96..28299f0 100644
> --- a/o3tl/inc/o3tl/vector_pool.hxx
> +++ b/o3tl/inc/o3tl/vector_pool.hxx
> @@ -65,7 +65,7 @@ namespace o3tl
>                   }
>                   else
>                   {
> -                    push_back(value_type(rCopy));
> +                    this->push_back(value_type(rCopy));
>                       return this->size()-1;
>                   }
>               }
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
thanks again for the patch, please in future could you think about 
rolling up the patches where that obviously makes sense

patch is pushed, 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2a634416ba8f385c25c16cc52aeae6f68cab9db
( and also the following patch )

Noel