Re: [Libreoffice] [PATCH] fix cosv build

On 10/08/11 17:54, Tom Tromey wrote:
> I tried building LibreOffice with svn trunk gcc; though in this case the
> bug seems to be a fairly generic include order problem.
>
> The build dies in cosv with:
>
> Compiling: cosv/source/strings/string.cxx
> In file included from ../../inc/cosv/string.hxx:33:0,
>                   from ../../inc/cosv/csv_precomp.h:39,
>                   from ../inc/precomp.h:32,
>                   from 
> /home/tromey/Space/LibreOffice/bootstrap/clone/sdk/cosv/source/strings/string.cxx:29:
> ../../inc/cosv/stringdata.hxx: In instantiation of 'csv::StringData<CHAR>::StringData(const CHAR*, 
> csv::StringData<CHAR>::size_type) [with CHAR = char, csv::StringData<CHAR>::size_type = long unsigned 
> int]':
> /home/tromey/Space/LibreOffice/bootstrap/clone/sdk/cosv/source/strings/string.cxx:75:17:   required 
> from here
> ../../inc/cosv/stringdata.hxx:105:5: error: 'memcpy' was not declared in this scope, and no 
> declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
> /usr/include/string.h:44:14: note: 'void* memcpy(void*, const void*, size_t)' declared here, later 
> in the translation unit
> dmake:  Error code 1, while making '../../unxlngx6.pro/obj/string.obj'
>
>
> string.hxx includes<string.h>, which declares memcpy, after
> cosv/stringdata.hxx.  Moving<string.h>  earlier fixes the problem.
>
> This is contributed under the LGPLv3+/MPL.
pushed to master 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a35f23a2ccb17c3e8e0cb218bb1cf886b4c7124

thanks for the patch!!, but... could you please attach future patches 
using git format-patch ( or something ), this would make applying the 
patches nice and easy for us

Noel