Re: [Libreoffice] [PATCH] fix for fdo#39678: don't write table:protection-key-digest-algorithm to odf 1.1 or odf 1.0

Hi Markus,

On Fri, 2011-08-05 at 22:01 +0200, Markus Mohrhard wrote:
> Hello,
>
> this patch should ensure that we write the password algorithm only to
> odf 1.2 and later files.
>
> I'm not quite sure how important it is to be 100% standard compliant
> so I don't know if we should include it into 3-4.

Well, I do know that 100% standard compliance *does* matter to some
circle of users, so as long as the fix is a safe fix, I would say we
should put it in.

I would make one change though.  Instead of

if ( IsOdfVersionGreaterEqual_1_2() )

we should do

if (getDefaultVersion() >= SvtSaveOptions::ODFVER_012)

and drop the additional method you added in your patch.
Conditionalizing for the ODF version 1.2 or above is common enough that
it is done in many other places, and this is how it is done there.

Other than that, the patch looks good & safe.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida@suse.com>