Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Bjoern,

On Friday, 2011-08-05 00:02:53 +0200, Bjoern Michaelsen wrote:

> UCBHELPER_DLLIMPLEMENTATION is set during the compiles.

That seems to be the underlying cause: UCBHELPER_DLLIMPLEMENTATION is
_not_ set during compilation, Library_ucbhelper.mk has

$(eval $(call gb_Library_add_defs,ucbhelper,\
    -DUCBHELPER_DLLIMPLEMENTATION \
))

note _ADD_defs, solenv/gbuild/templates/Library.mk though says

# add any additional definitions to be set for compilation here
# (e.g. -DLIB_DLLIMPLEMENTATION)
$(eval $(call gb_Library_set_defs,LIB,\
        $$(DEFS) \
))

note _SET_defs, so I changed that to

$(eval $(call gb_Library_set_defs,ucbhelper,\
    $$(DEFS) \
    -DUCBHELPER_DLLIMPLEMENTATION \
))

and that works. Apparently all modules newly converted to gbuild have
that wrong.

  Eike

-- 
 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

Attachment: pgpjj_j4ihEqW.pgp
Description: PGP signature