[Libreoffice] windows dependency tool and GenCxxObjects

Trying to see why my windows build just loop endlessly in basegfx with
unfulfilled dependencies I see that the target in basegfx is a
GenCxxObject, now...

solenv/gbuild/LinkTarget.mk

is...


$(call gb_GenCxxObject_get_target,%) : $(call
gb_GenCxxObject_get_source,%)
        $(call gb_CxxObject__command,$@,$*,$<,$(call
gb_GenCxxObject_get_dep_target,$*))

so the GenCxxObject calls gb_CxxObject__command

the solenv/gbuild/platform/windows.mk has...

define gb_CxxObject__command
$(call gb_Output_announce,$(2),$(true),CXX,3)
...
... gb_CxxObject_get_dep_target,$(2))
...

When its a GenCxxObject that's the wrong target, right. i.e. it should
be gb_GenCxxObject_get_dep_target not gb_CxxObject_get_dep_target.

And anyway, don't we have this already available as $4 ?

The attached patch allows me to build build basegfx again anyway under
windows. Is it right ?

C.

diff --git a/solenv/gbuild/platform/windows.mk b/solenv/gbuild/platform/windows.mk
index 6202a4b..915280f 100644
--- a/solenv/gbuild/platform/windows.mk
+++ b/solenv/gbuild/platform/windows.mk
@@ -304,7 +304,7 @@ $(call gb_Helper_abbreviate_dirs_native,\
                -I$(realpath $(dir $(3))) \
                $(INCLUDE_STL) $(INCLUDE) \
                -c $(realpath $(3)) \
-               -Fo$(1))  $(call gb_create_deps,$(1),$(call 
gb_CxxObject_get_dep_target,$(2)),$(realpath $(3)))
+               -Fo$(1))  $(call gb_create_deps,$(1),$(4),$(realpath $(3)))
 $(call gb_Object__command_deponcompile,$(1),$(4),$(3),$(DEFS),$(T_CXXFLAGS),$(INCLUDE))
 endef