Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx

Norbert Thiebaud <nthiebaud -AT- gmail.com>
Wed, 3 Aug 2011 10:43:36 -0500

2011/8/3 Tomáš Chvátal <tchvatal@novell.com>:

Dne 3.8.2011 13:27, Caolán McNamara napsal(a):


On Wed, 2011-08-03 at 12:11 +0100, Caolán McNamara wrote:


On Wed, 2011-08-03 at 12:47 +0200, Tomáš Chvátal wrote:


Attaching the updated patch that adds it only where it should really be
needed.


seems reasonable, pushed.


*bzzt*, x86_64 gcc 4.3.4 doesn't support it, so breaks the build on
those buildbots.

I guess need to instead add a configure check for it, stuff it into an
env variable if supported, and add that env variable to the makefile.mks
instead.

C.

Darn,
Ok first part is the configure.in check, I think the attachment should do
the trick.

But I am not entirely sure how to do the check in plain GNUMake.
I wrote it with ifdef USE_AVX and I hope this is the way it should work :)


I haven't read the patch, but you should use HAVE_GCC_AVX to stay
similar to existing check like that.

Norbert

Context

[Libreoffice] [PATCH] Fix building bridge with -mavx · Tomas Chvatal
- Re: [Libreoffice] [PATCH] Fix building bridge with -mavx · Caolán McNamara
  - Re: [Libreoffice] [PATCH] Fix building bridge with -mavx · Tomáš Chvátal
    - [Libreoffice] [PUSHED][PATCH] Fix building bridge with -mavx · Caolán McNamara
      - [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Caolán McNamara
        
        Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Tomáš Chvátal
        
        Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Norbert Thiebaud
        
        Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Tomáš Chvátal
        Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Norbert Thiebaud
        Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Tomáš Chvátal
        Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx · Norbert Thiebaud
        
        [Libreoffice] [REPUSHED][PATCH] Fix building bridge with -mavx · Caolán McNamara
- Re: [Libreoffice] [PATCH] Fix building bridge with -mavx · Stephan Bergmann
  - Re: [Libreoffice] [PATCH] Fix building bridge with -mavx · Caolán McNamara
    - Re: [Libreoffice] [PATCH] Fix building bridge with -mavx · Jan Holesovsky

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.