Re: [Libreoffice] [PATCH] produce smaller .res files with the resource compiler

On Sun, 2011-07-24 at 08:48 -0500, Norbert Thiebaud wrote:
> Are you sure you actually saved that 'much' ? presumably this 2158
> bytes repeated 71 times should compress well enough when packaged

        Well - it is repeated umpteen times per language; and how well that
compresses is anyone's guess.

> > Please review it, I'm not sure if such low level hacks are acceptable. :)
>
> Looks pretty ugly to me. That code seems neglected enough without
> adding another layer of WTF-factor for the poor soul that one day will
> want/have to maintain it.

        Quite - that was a nightmare of a patch ;-) Luckily a spent a few
minutes while running a backup to turn it into something nicer:

        I think this is more like what you want to be doing. We would
want to remove the code that dumps this table in tools/ - it seems
to be only enabled as DBG_UTIL - and (as you say) seems to be unused.

        Potentially, if we were a bit braver; we could (I guess)
experiment with shrinking nRT's size down to sal_uInt16 (at least in the
file format), and see if nId is really necessary in those headers - but
perhaps I'm missing something there. No doubt it would be worth doing
some fprintf goodness during an incremental re-build of all the resource
files to work out what the scopes are there.

        Anyhow - needs a bit more testing of course, but hopefully is
maintainable. It shrinks:

cd filter/
touch ./source/graphicfilter/eps/epsstr.src
build && hexdump -C ./unxlngi6.pro/bin/epsen-US.res

        quite touchingly :-) I'd like to see the RSC_VERSIONCONTROL record
completely expunged from the code (ideally) on both sides and the
headers, completely gone.

        ATB,

                Michael.

From 56991b23947d7d2307cc4bc039b8b0a2a0cd8da1 Mon Sep 17 00:00:00 2001
From: Michael Meeks <michael.meeks@novell.com>
Date: Mon, 1 Aug 2011 17:36:56 +0100
Subject: [PATCH] remove name-to-ver-control map contents from RSC_VERSIONCONTROL record

Based on a patch from Andras, this removes a set of un-used
debugging type strings from all lang-pack resource files.
---
 rsc/source/parser/rscinit.cxx |   24 ------------------------
 1 files changed, 0 insertions(+), 24 deletions(-)

diff --git a/rsc/source/parser/rscinit.cxx b/rsc/source/parser/rscinit.cxx
index ae6b7b6..b4591bd 100644
--- a/rsc/source/parser/rscinit.cxx
+++ b/rsc/source/parser/rscinit.cxx
@@ -58,29 +58,6 @@
 #define INS_WINBIT( pClass, WinBit )           \
     InsWinBit( pClass, #WinBit, n##WinBit##Id );
 
-/****************** C O D E **********************************************/
-void NameToVerCtrl( RSCINST & aVersion, RscTop * pClass,
-                    RscTop * pClassString )
-{
-    if( pClass )
-    {
-        NameToVerCtrl( aVersion, (RscTop *)pClass->Left(), pClassString );
-        {
-            RSCINST aVI;
-            RSCINST aStr;
-
-            // Namen in Versionskontrolle einsetzen
-            aVersion.pClass->
-                  GetElement( aVersion, RscId( pClass->GetTypId() ),
-                              pClassString, RSCINST(), &aVI );
-            aStr = aVI.pClass->GetVariable( aVI, pHS->getID( "TEXT" ),
-                                            RSCINST() );
-            aStr.pClass->SetString( aStr, pHS->getString( pClass->GetId() ).getStr() );
-        }
-        NameToVerCtrl( aVersion, (RscTop *)pClass->Right(), pClassString );
-    }
-}
-
 /*************************************************************************
 |*
 |*       RscTypCont::Init()
@@ -926,7 +903,6 @@ void RscTypCont::Init()
     pClassSfxSlotInfo = InitClassSfxSlotInfo( pClassMgr );
     pRoot->Insert( pClassSfxSlotInfo );
 }
-    NameToVerCtrl( aVersion, pRoot, pClassString );
 
     aNmTb.SetSort();
 }
-- 
1.7.3.4

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot