Re: [Libreoffice] Link external libraries before internal ones

Petr Mladek píše v Pá 29. 07. 2011 v 16:40 +0200:
> Hi Bjoern,
>
> --as-needed link flag has been enabled by default since openSUSE-11.3 or
> so. It requires to mention libraries in the link flags in the right
> order. I have troubles to link libqstart_gtklx.so. I get:
>
> In fact, the 3rd party libraries should be mentioned at the end of the
> command line because neither of use symbols from the internal libraries.
>
> I am a bit lost how to solve this with the GNU make. Could you please
> help me?

Heh, I have asked for help too fast. The attached patch does the job
here.

I have to try a clean build. If there are no objections, I will do this
change in master.


Best Regards,
Petr

--- solenv/gbuild/platform/unxgcc.mk.old        2011-05-20 18:04:45.000000000 +0200
+++ solenv/gbuild/platform/unxgcc.mk    2011-07-29 16:50:15.000000000 +0200
@@ -236,13 +236,14 @@ $(call gb_Helper_abbreviate_dirs,\
        mkdir -p $(dir $(1)) && \
        $(gb_CXX) \
                $(if $(filter Library CppunitTest,$(TARGETTYPE)),$(gb_Library_TARGETTYPEFLAGS)) \
-               $(subst \d,$$,$(RPATH)) $(LDFLAGS) \
+               $(subst \d,$$,$(RPATH)) \
                $(foreach object,$(COBJECTS),$(call gb_CObject_get_target,$(object))) \
                $(foreach object,$(CXXOBJECTS),$(call gb_CxxObject_get_target,$(object))) \
                $(foreach object,$(GENCXXOBJECTS),$(call gb_GenCxxObject_get_target,$(object))) \
                $(foreach extraobjectlist,$(EXTRAOBJECTLISTS),`cat $(extraobjectlist)`) \
                -Wl$(COMMA)--start-group $(foreach lib,$(LINKED_STATIC_LIBS),$(call 
gb_StaticLibrary_get_target,$(lib))) -Wl$(COMMA)--end-group \
                $(patsubst lib%.so,-l%,$(foreach lib,$(LINKED_LIBS),$(call 
gb_Library_get_filename,$(lib)))) \
+                $(LDFLAGS) \
                -o $(1))
 endef