[Libreoffice] [REVIEWED, 1 more for 3-4-2] Re: [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection

Jan Holesovsky <kendy -AT- suse.cz>
Tue, 19 Jul 2011 13:55:14 +0200

Hi,

On 2011-07-19 at 12:05 +0100, Caolán McNamara wrote:

Looks fine except for a typo in scriptListCount definition. I have fixed
it by
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=bfa455e31ab2356b4ee0cf499bb71138e837e6c7

Could you please approve this typo fix?


Oops, yes. That looks right.


One more review from me; I have pushed it to libreoffice-3-4.

One last review + push to -3-4-2 needed.

Regards,
Kendy

Context

[Libreoffice] A thought about fdo#38095: Character classification for Western or Asian text font · Takeshi Abe
- Re: [Libreoffice] A thought about fdo#38095: Character classification for Western or Asian text font · Caolán McNamara
  - Re: [Libreoffice] A thought about fdo#38095: Character classification for Western or Asian text font · Takeshi Abe
- [Libreoffice] [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection · Caolán McNamara
  - Re: [Libreoffice] [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection -- 2 more reviews needed · Fridrich Strba
    - Re: [Libreoffice] [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection -- 2 more reviews needed · Tor Lillqvist
      - Re: [Libreoffice] [REVIEWED] cherry-picking fix for fdo#38095, character classification for font selection -- 2 more reviews needed · Michael Meeks
  - Re: [Libreoffice] [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection · Petr Mladek
    - Re: [Libreoffice] [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection · Caolán McNamara
      - [Libreoffice] [REVIEWED, 1 more for 3-4-2] Re: [REVIEW] cherry-picking fix for fdo#38095, character classification for font selection · Jan Holesovsky

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.