Re: [Libreoffice] Replacing ByteString with rtl::OString

On Tue, 2011-07-12 at 21:18 +0200, Chr. Rossmanith wrote:
> Hi,
>
> next problem: there is no IsNumericAscii() for O(U)String but for 
> ByteString. Should O(U)String get this method as well?

Don't know if its really widely used enough to warrant expanding the
O[U]String API ? You could perhaps re-implement it in terms of a OString
and move it to be a helper method in comphelper, i.e.
comphelper/inc/comphelper/string.hxx which is the home of useful string
utilities which aren't great fits for the public api, e.g. Sébastien's
cool decimalStringToNumber which knows about non-standard unicode
numerals and can do basically a toInt32 on those.

As an aside, see https://bugs.freedesktop.org/show_bug.cgi?id=34779 and
commit
http://cgit.freedesktop.org/libreoffice/writer/commit/?id=65d3573c5afd7fd132b30c41a240d1d2d04c8527
for the kind of goodness that flows out of ByteString->OString and
UniString->OUString overhauls.

C.