On Tue, 2011-07-12 at 12:51 +0200, Radek Doulik wrote:
Hi Caolán,
the patch looks good to me.
I am also surprised by the speedup (given that it always inserts at the
end of the vector array in your case). Hard to check without the actual
document. Might be problem in std::vector not detecting that the rest of
reserved space doesn't need to be moved or something?
Yeah, that's sort of what it looks like, though for me the whole
callstack ends up setting up camp in some -DFORTIFY->selinux chain of
goo.
You might try to load the document into valgrinded libreoffice just to
be sure that it doesn't mess memory.
Yeah, my test-case is good under valgrind FWIW.
C.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.