Hi Muthu, On Thu, 2011-07-07 at 18:39 +0530, Muthu Subramanian K wrote:
It would be great if somebody can review and cherry pick these fixes: http://cgit.freedesktop.org/libreoffice/filters/commit/?id=8faf3f2e8b085285b51bd6a993efd2c9f68714d1
This sort of stuff: + if( bShowValue && + !bShowPercent && rTypeInfo.meTypeCategory == TYPECATEGORY_PIE && + rDataLabel.maNumberFormat.maFormatCode.indexOfAsciiL("%", 1) >= 0 ) + { + bShowValue = false; + bShowPercent = true; + } makes me wonder if we don't want that in our own pie chart implementation rather than in the filter though ... :-) But I picked it for -3-4.
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=7589a8d3f6d3cb9f08f39059dedf05b7636cbc0f
Picked for 3-4 - though I'd be interested to know who needs to read these later. ATB, Michael. -- michael.meeks@novell.com <><, Pseudo Engineer, itinerant idiot