Re: [Libreoffice] LibreOffice (filters) mrcekets * filter/source/svg/ (7 files): Enhancing svg export

Hi Joseph,
I applied your patch and works smoothly.
I'll integrate it in my next commit/patch-set.

Cheers,
     Marco


On Fri, 08 Jul 2011 07:50:56 +0200, Joseph Powers <jpowers27@cox.net>
wrote:

> Can you verify that I didn't break your patch?
>
> My compiler (i686-apple-darwin10-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build  
> 5494)) didn't like some of your code:
>
> /Users/jpowers27/LibO/clone/filters/filter/source/svg/svgexport.cxx: In  
> member function 'sal_Bool SVGFilter::implExportDocument()':
> /Users/jpowers27/LibO/clone/filters/filter/source/svg/svgexport.cxx:798:  
> error: call of overloaded 'valueOf(int)' is ambiguous
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1371:  
> note: candidates are: static rtl::OUString  
> rtl::OUString::valueOf(sal_Bool)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1385:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Unicode)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1399:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Int32, sal_Int16)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1416:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Int64, sal_Int16)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1432:  
> note:                 static rtl::OUString rtl::OUString::valueOf(float)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1448:  
> note:                 static rtl::OUString rtl::OUString::valueOf(double)
> /Users/jpowers27/LibO/clone/filters/filter/source/svg/svgexport.cxx:799:  
> error: call of overloaded 'valueOf(int)' is ambiguous
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1371:  
> note: candidates are: static rtl::OUString  
> rtl::OUString::valueOf(sal_Bool)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1385:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Unicode)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1399:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Int32, sal_Int16)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1416:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Int64, sal_Int16)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1432:  
> note:                 static rtl::OUString rtl::OUString::valueOf(float)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1448:  
> note:                 static rtl::OUString rtl::OUString::valueOf(double)
> /Users/jpowers27/LibO/clone/filters/filter/source/svg/svgexport.cxx: In  
> member function 'long int SVGFilter::CalcFieldHdl(EditFieldInfo*)':
> /Users/jpowers27/LibO/clone/filters/filter/source/svg/svgexport.cxx:1900:  
> error: call of overloaded 'valueOf(sal_Int16&)' is ambiguous
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1371:  
> note: candidates are: static rtl::OUString  
> rtl::OUString::valueOf(sal_Bool)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1385:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Unicode)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1399:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Int32, sal_Int16)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1416:  
> note:                 static rtl::OUString  
> rtl::OUString::valueOf(sal_Int64, sal_Int16)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1432:  
> note:                 static rtl::OUString rtl::OUString::valueOf(float)
> /Users/jpowers27/LibO/solver/350/unxmacxi.pro/inc/rtl/ustring.hxx:1448:  
> note:                 static rtl::OUString rtl::OUString::valueOf(double)
> dmake:  Error code 1, while making '../../unxmacxi.pro/slo/svgexport.obj'
>
> My patch is: Fix some ambiguous method errors.
> commit  bcf2a91f74e5c9ffe4b2978d53b7031a85d89ae4 (patch)
>
> Thanks,
> Joe P.


--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/