Re: [Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells

Hi,

Am 04.07.2011 15:32, schrieb Katarina Machalkova:
> Well done! Attached is a small modification to the code (and the function) 
> I've made. I.e. it makes sense to allow user to define grid colour (and thus 
> enable fixed text & related listbox) in both cases when the grid is enabled -- 
> in both "show" and "show on colored cells" case.

Yes, please apply with the modifications.

While

-    if ( bGrid )
+    if ( bGrid || bGridOnTop )


just makes more obvious, what happens - the other one

-    aColorFT.Enable(bGridOnTop);
-    aColorLB.Enable(bGridOnTop);
+    aColorFT.Enable(bGrid);
+    aColorLB.Enable(bGrid);

is a real error :(

> Also, before I really push the patch -- may I suggest some change to the 
> wording being used? 
> "Show on colored cells" sounds sliiiightly misleading to me, as the grid is 
> shown everywhere (all over the sheet), not only over the cells filled by some 
> colour. Something along "Show always on top" or "Show in the foreground" line 
> would imao describe its function much better ... Consequently, the option name 
> would become GridOnTop, or GridInForeground, but that's just nitpicking ...


This had been discussed at some point (actually I did prefer "on top" as
you see in the implementation). But comments showed that "on top" or "in
foreground" is not a much better description. The grid is not really on
top, as it is still behind drawing elements, notes ... So I'd rather
stay with the current strings.


thanks and regards,

André