Re: [Libreoffice] [REVIEW] [PUSHED] fdo#38457: Crash in DataPilot on moving the fields

Hello Kohei,

thanks that you had a quick look at this patch.

2011/6/30 Kohei Yoshida <kohei.yoshida@gmail.com>

> The last time I checked, in the old code bForFile could still be true.
>  I also assumed that it was always false and removed the if statement,
> but that caused a crasher bug (because it could be true sometimes).
> Since then I've refactored that code but the new code still contained
> the if block to reflect the old behavior.
>
> Have you guys checked a scenario where the source data range begins
> with a column other than Column A?  That's when the nSrcColOffset can
> become non-zero, and setting it to always zero *might* break it
> especially for that scenario.  So, before committing that fix, I'd
> like that scanrio to be tested just to feel safe and secure.

I've checked this now but can't create any crashes. But as much as I see
from some other bug reports, there are more problems with pivot tables at
the moment and not all seem to be reproducible in all environments.
I think it might be best that we don't change anything further in the pivot
table code and you have a look at it when you're back.

Have a nice holiday.

Regards,
Markus