Re: [Libreoffice] [REVIEW] fix for fdo38204: formulas with range names were not imported correctly from xls

Noel Power <nopower -AT- novell.com>
Thu, 23 Jun 2011 09:27:41 +0100

On 22/06/11 19:44, Markus Mohrhard wrote:

Hello all,
I have a new patch for another problem around range names. We couldn'timport formulas with range names from xls due to a false check.The named range index is 1-based during import and so the check isonly allowed to check for > but not >=.
I think we should include this patch into 3-4 because it is a seriousproblem if all formulas with range names are screwed up.
Regards,
Markus

looks good to me, please commit to master, let me know the commit id andI will cherrypick/signoff for 3.4

thanks again for another great catch

Noel

Context

[Libreoffice] [REVIEW] fix for fdo38204: formulas with range names were not imported correctly from xls · Markus Mohrhard
- Re: [Libreoffice] [REVIEW] fix for fdo38204: formulas with range names were not imported correctly from xls · Noel Power
  - Re: [Libreoffice] [REVIEW] fix for fdo38204: formulas with range names were not imported correctly from xls · Markus Mohrhard
    - Re: [Libreoffice] [PUSHED][REVIEW] fix for fdo38204: formulas with range names were not imported correctly from xls · Noel Power

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.