Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


I'm sending the patch for review; not because it needs a lot but just to have someone verify that 
the memory was leaking and needs to be fixed.

Current fixes:
1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it.

Future Fixes:
1.   List* pBmpList; Should be replaced with a std::vector< Bitmap*>
2. I thinking that once pBmpList is a vector<> I should cleanup the constructors that pass initial 
size and resize values.
3. I'm noticing that several methods have extra parameters that aren't used. Should I include a 
patch to clean them up also?

Thanks,
Joe P.

Attachment: 0001-Replace-List-with-std-vector-XPropertyEntry.patch
Description: Binary data


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.