Re: [Libreoffice] [REVIEWED][PUSHED-3-4-1] fix for fdo#37771

Petr Mladek <pmladek -AT- suse.cz>
Fri, 17 Jun 2011 12:06:12 +0200

cbosdonnat píše v Pá 17. 06. 2011 v 01:12 -0700:

Caolán McNamara wrote:


On Thu, 2011-06-16 at 18:39 +0200, Andras Timar wrote:

Hi,

Writer requires a password with <random number> characters. Instead of
fixing the code in Writer (SfxPasswordDialog::SetMinLen was not called
somewhere) I set a default minimum password length in constructor of
the dialog. Please review it for 3-4 and 3-4-1.

http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=6ab5952f6d952e5f96428b631e91a208ea21d4aa


Looks sane, +1, one more needed for 3.4.1.


Looks sane to me too.


This was 3rd review and I see it pushed in libreoffice-3-4-1 branch.


Best Regards,
Petr

Context

[Libreoffice] [REVIEW] fix for fdo#37771 · Andras Timar
- Re: [Libreoffice] [REVIEW] fix for fdo#37771 · Tor Lillqvist
- [Libreoffice] [REVIEW] fix for fdo#37771 · Caolán McNamara
  - Re: [Libreoffice] [REVIEWED] fix for fdo#37771 · cbosdonnat
    - Re: [Libreoffice] [REVIEWED][PUSHED-3-4-1] fix for fdo#37771 · Petr Mladek
      - Re: [Libreoffice] [REVIEWED][PUSHED-3-4-1] fix for fdo#37771 · Cedric Bosdonnat
- Re: [Libreoffice] [REVIEW] fix for fdo#37771 · Jean-Baptiste Faure

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.