Re: [Libreoffice] [PATCH] Adabas D client library

Francois Tigeot píše v Ne 12. 06. 2011 v 08:17 +0200:
> On Sat, Jun 11, 2011 at 02:46:58PM +0200, Francois Tigeot wrote:
> > In light of my recent findings, I have become convinced Adabas D is not used
> > and will not be in the future.
> >
> > We could kill two birds with one stone by simply disabling the build of this
> > library.

Great idea!

> The attached patch disables the Adabas D client library in -master (but does
> not remove the driver code itself).

Hmm, the patch just disables installation. I am not that happy with such
partial solution. It leaves mess in the sources. I would prefer to
either make the build/installation optional or remove the code at all.

IMHO, about the code removal should decide LO steering committee.
Michael?

I personally like the idea to remove the code at all. You did a nice
analyze [1]! It seems that it was included only because of compatibility
with the historic StarOffice 7. I guess that it is not tested or
maintained in LO.

If we decide to make the code optional, we need to modify:

   bootstrap/configure.in
   bootstrap/set_soenv.in
   libs-core/connectivity/source/drivers/adabas/makefile.mk
   bootstrap/scp2/source/ooo/makefile.mk
   bootstrap/scp2/source/ooo/file_library_ooo.scp

You might find an inspiration in the Evolution driver. Try to search
ENABLE_EVOAB2 at http://opengrok.libreoffice.org/


Reference:
[1]
http://lists.freedesktop.org/archives/libreoffice/2011-June/013658.html


Best Regards,
Petr


PS: If you have a patch for review, please mention [PATCH] in the
subject ;-)