Re: [Libreoffice] [REVIEWED] [PUSHED] fix for fdo#37872

On Fri, 2011-06-10 at 16:27 +0200, Markus Mohrhard wrote:

> this patch is for https://bugs.freedesktop.org/show_bug.cgi?id=37872 .
> I discussed the underlying problem with Kohei and we agreed that we
> should not allow points in range names any more. There are even more
> problems with points in range names than discussed in this bug report
> because points are used to seperate table names from cell address. 

Hi Markus,

The patch looks good, and I've sign-off on this & pushed to the -3-4
branch.  Thanks a lot for looking into this.

Just for an idea, we probably should disallow '!' also since we support
Excel A1 and Excel R1C1 formula syntax where '!' is used as the
separator.  But we can do that separately.

> This patch only avoids that new range names with points are created
> but will not deal with range names during import. This is much more
> difficult and nothing I want to introduce into 3.4.1. 

Yes.  Solving this is a bit tricky.  I don't have a good suggestion at
the moment so let's flag this as a known issue (in case someone asks),
and tries to figure out a way to solve it.

Best,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>