Ok. This is the last one for today.
Here is the bug
https://bugs.freedesktop.org/show_bug.cgi?id=37622
and here is the commit I'd like to cherry-pick to the -3-4 branch
http://cgit.freedesktop.org/libreoffice/calc/commit/?id=099fd0fd91485797362259e45b1a971dda0511a3
The old code incorrectly returned NULL when the last font ID was passed,
because of the wrong boundary check.
In XLS, font IDs are zero-based when it's less than 4, but it becomes
one based when greater than 4 according to the spec. This lookup
behavior was accidentally altered during ScfDefList removal.
Review & sign-off appreciated.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>
Context
- [Libreoffice] [REVIEW] Fix for fdo#37622 · Kohei Yoshida
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.