Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


On Wed, Jun 8, 2011 at 5:32 AM, Samuel Mehrbrodt
<s.mehrbrodt@googlemail.com> wrote:
Hi,

When I wanted to commit, git complained about remaining tabs and so I
also replaced them with spaces. That makes the patch look bigger than it
actually was, but I didn't see another way.

You could have edited the patch afterward to remove the un-needed section...
that is easier done with a patch-aware editor, like emacs (and most likely vim)
But in thta case, all that was needed was to remove the chunk that
were just tab/whitespace related
for reference : here is the edited version... which applied cleanly.


The actual changes in the patch are in line 20 (import) and from line
580 down (removed lcl_TransliterateEditEngine and changed
ScDocument::TransliterateText).

This is my first contribution to LO, so I'm open for your feedback :)

First: Welcome aboard :-)

Second, few remarks, feedback.

It would be great if:
* you added In the subject use [PATCH] (with the bracket and the
capitalization... that help us spotting these :-)
* you indicate that you build the patched version
* you indicate what you did if any to verify the resolution of the bug.

So, I tweaked the patch to remove the space/tab chunks, applied it and
run test test scenario in fdo#32786.
It works fine...
I did not reproduce the bug _before_ applying the patch (not that I
couldn't reproduce, but I did not - shame on me :-) )

in any case: Pushed to master, and I closed the bug..

Thanks again.

Norbert



[1] https://bugs.freedesktop.org/show_bug.cgi?id=32786
[2] http://hg.services.openoffice.org/OOO340/rev/de0464b37fb3

These links above were very useful, thanks, keep doing that :-)

Attachment: 0001-Fix-for-fdo-32786-Capitalise-Every-Word-function.patch
Description: application/mbox


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.