Re: [Libreoffice] [REVIEW] Fix for fdo#33705

On Wed, 2011-06-08 at 15:10 -0400, Kohei Yoshida wrote:
> I'd like to have the following commit
>
> http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5743e7b36220e9689091812cef7a4396dd48c4e6
>
> cherry-picked to the -3-4 branch in order to fix
>
> https://bugs.freedesktop.org/show_bug.cgi?id=33705

Several people have told me that the unit test introduced in this commit
fails.  If you experience this, please try changing

m_pDoc->SetString(0, 6, 0,
    OUString(RTL_CONSTASCII_USTRINGPARAM("TRUE")));
m_pDoc->SetString(0, 7, 0,
    OUString(RTL_CONSTASCII_USTRINGPARAM("FALSE")));

to

m_pDoc->SetString(0, 6, 0,
    OUString(RTL_CONSTASCII_USTRINGPARAM("=TRUE()")));
m_pDoc->SetString(0, 7, 0,
    OUString(RTL_CONSTASCII_USTRINGPARAM("=FALSE()")));

to see if that will solve the unit test failure issue.  The test passes
in my build environment so I'm suggesting this entirely in blind, so I
don't want to check this in before confirming that this is indeed the
issue.

Thanks,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>