Re: [Libreoffice] [REVIEW] fix for fdo#37584

John LeMoyne Castle <lemoyne.castle -AT- gmail.com>

Wed, 8 Jun 2011 08:54:00 -0700 (PDT)

Cedric, I apologize for the time cost for you to dig this up. I do remember removing a string copy (or maybe two?). I should have clearly seen the need for a full copy after digging into the counting process and seeing the changes it made to the string in order to count excluding hidden or redlined, Definitely my bad for not testing more use cases (redlining). I will go back and review my work in this area. I see that this is marked as a regression against 3.3.2 and yet the word count work was well over 6 months ago. I had thought that word count w/ and w/out spaces had rolled out prior to 3.3.2 Perhaps the problem exists (undiscovered) in 3.3.2 as well. jlc -- View this message in context: http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37584-tp3038258p3039644.html Sent from the Dev mailing list archive at Nabble.com.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.