Re: [Libreoffice] Need help to fix issue 75199

On Thu, 2011-06-02 at 18:23 +0200, Jean-Baptiste Faure wrote:

> It is easy to replace the string SCWARN_IMPORT_RANGE_OVERFLOW by
> SCWARN_IMPORT_COLUMN_OVERFLOW but I do not know if it is the right
> solution.

No, that would only shift the problem.  With that, all the row overflow
is now reported to the user as the column overflow problem.  That won't
be good.

You need to first find out *why* bOverflow becomes true.  Who sets its
value, and what the cause of that is.  The right fix will all depend on
the outcome of that.

>  Indeed it is not clear for me if, when the variable bOverflow
> is set at true, we know if it is a problem with rows or with columns.

Exactly.  You need to find this out first and foremost.  It's possible
that the problem is caused by something other than a simple column
overflow, so we need to make sure that we know what's causing the
problem.

> The name of the current string message suggests that we do not know.
> In that case maybe the right solution is to modify the message itself
> with a less precise content. Perhaps something like
> "The maximum number of rows or columns has been exceeded. Excess rows
> and columns were not imported!".

That may provide a technically correctly solution, but IMO this would
degrade the overall user experience.  I would like us to at least
differentiate whether it's a column overflow or a row overflow problem,
which would also help us debug future problems in this area easier down
the road.

> So what do you prefer to fix this bug?
> 1/ replace SCWARN_IMPORT_RANGE_OVERFLOW by SCWARN_IMPORT_COLUMN_OVERFLOW
> because excess of column maybe is more probable. The most easy fix but
> surely not the best.
> or
> 2/ change the content of SCWARN_IMPORT_RANGE_OVERFLOW
> or
> 3/ something else but what ?

Find out what exactly is causing the overflow flag to be set, and devise
a solution based on that.  This would be my preferred solution.

HTH,

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>