Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index



On Tue, 2011-05-31 at 11:58 +0200, David Tardon wrote:
On Tue, May 31, 2011 at 10:27:19AM +0100, Michael Meeks wrote:
+            PTR_CAST(BasicCollection,pVar) == pCollection )

    I'll commit that, and wait for screams.

Moreover, I think there should be p = p->pNext at the end of the loop.
Otherwise we either hit the right collection at first try or we are
cycling until the heat death of the Universe .-)

        Lol. And of course, it looks like nested foreaches on the same
collection would also break [ though it's not that likely to be
sure ;-]. I added to your clean by using a for(;;) loop to make it
clearer.

        Thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.