Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

Michael Meeks <michael.meeks -AT- novell.com>
Tue, 31 May 2011 12:53:31 +0100


On Tue, 2011-05-31 at 18:23 +0700, Korrawit Pruegsanusak wrote:

Maybe I'm late, but I confirm.


        Thanks :-) helps speedup patch inclusion to have that each time, though
(as Noel says) I'd pushed it already.

And may I ask again that:

I've found some comments are unreadable, eg. in
http://opengrok.libreoffice.org/xref/filters/hwpfilter/source/hwpreader.cxx#630
Should we also remove them?


        Sounds good ;-) if it is just unreadable nonsense of no value - it
should go.

 * parse automatic styles from hwpfile
 * ?????????? ?????? ???? ???????? ????????. ???????? ?????? ????????, ??????, ???? ?????? ???????? 
???????? ????????, Body?????? ?????? ?????? ???????? ????????.
 * 1. paragraph, text, fbox, page???????? ???? ????????.

        I'd just kill the ?s ;-)

        Thanks,

                Michael.

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

Context

[Libreoffice] [PATCH] Code cleanup in filters · Korrawit Pruegsanusak
- Re: [Libreoffice] [PATCH] Code cleanup in filters · Michael Meeks
- Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Noel Power
  - Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Korrawit Pruegsanusak
    - Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Michael Meeks
      - Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Joop Kiefte
        
        Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Korrawit Pruegsanusak
        
        Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Christian Lohmaier
        
        Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Joop Kiefte
        
        Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Christian Lohmaier
        Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Michael Meeks
        Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters · Korrawit Pruegsanusak

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.