Re: [Libreoffice] [PATCH] fdo#32263 - Config file location

Hi Noel,

On Mon, 30 May 2011 21:40:59 +0100, Noel Power <nopower@novell.com> wrote:
> On 30/05/11 15:39, Takeshi Abe wrote:
> > Hi all,
> > (thanks to Noel, for helpful comments on its initial version and
> > suggesting to post to this list).
> ahem, I seem to have gotten the wrong end of the stick about some of the patch (
> or at least looking at it again I see that )
> > It seems to work well with master, but has one concern; the change
> > against common_brand.scp leads the path "$HOME/libreoffice" (not
> > "$HOME/.libreoffice") used in the fallback case,
> the fallback though is pretty unlikely right ? ( only for a huge path ) My main
> gripe was that the scp change looked like it would impact windows too, I didn't
> look past the small amount of context in the patch so didn't realise that the
> value for the config changed here is indeed for unix only.
Well the change against common_brand.scp is surrounded with #ifdef, so will not
affect to WNT nor to MACOSX. Or am I misunderstanding something?

Cheers,
-- Takeshi Abe

> >   which sounds
> > uncomfortable to some users including me.
> > Any thought
> as above
>
> Noel