Date: prev next · Thread: first prev next last
2011 Archives by date, by thread · List index


The attached patch fixes broken transposition during cell range pasting.
It's a simple one liner fix.

I need to have one sign-off to be included in the -3-4 branch.

Here is the link to the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=37356

Thanks!

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida@novell.com>
From 2c0b112cd3349c596cd5d3a6544a2d5372a145d4 Mon Sep 17 00:00:00 2001
From: Kohei Yoshida <kyoshida@novell.com>
Date: Thu, 26 May 2011 15:45:05 -0400
Subject: [PATCH] fdo#37356: Fix broken transposition during paste of cell range.

Refactoring of ScRangeList accidentally skipped the first element during
for loop.
---
 sc/source/core/data/clipparam.cxx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sc/source/core/data/clipparam.cxx b/sc/source/core/data/clipparam.cxx
index 7804bcc..bdef09c 100644
--- a/sc/source/core/data/clipparam.cxx
+++ b/sc/source/core/data/clipparam.cxx
@@ -175,7 +175,7 @@ void ScClipParam::transpose()
         SCCOL nColOrigin = p->aStart.Col();
         SCROW nRowOrigin = p->aStart.Row();
 
-        for ( size_t i = 1, n = maRanges.size(); i < n; ++i )
+        for ( size_t i = 0, n = maRanges.size(); i < n; ++i )
         {
             p = maRanges[ i ];
             SCCOL nColDelta = p->aStart.Col() - nColOrigin;
-- 
1.7.3.4


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.